Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19902
Opened a new PR to add the getDouble method.
https://github.com/apache/spark/pull/19921
---
-
To unsubscribe, e-mail:
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19902
cool! I will add that and submit a new PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19902
ah i see, yea looks like `getByte`, `getShort` won't be very useful, let's
add `getDouble`
---
-
To unsubscribe, e-mail:
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19902
great! Thanks @gatorsmile , @cloud-fan.
Yes. I would be happy to open a new PR to add the rest of them.
If I compare with the getXXX types in SparkConf, it looks like the only
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19902
thanks, merging to master!
@skambha would you like to open a new PR to add the rest of `getXXX`
methods?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84582/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)**
for PR 19902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84579/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84579 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)**
for PR 19902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84578/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84578/testReport)**
for PR 19902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)**
for PR 19902 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19902
great! Thanks @gatorsmile for your comments.
I have updated with code comments, please take a look. Thanks.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19902
LGTM except three comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84579 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)**
for PR 19902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84578/testReport)**
for PR 19902 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84514/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84514/testReport)**
for PR 19902 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19902
**[Test build #84514 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84514/testReport)**
for PR 19902 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19902
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19902
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
25 matches
Mail list logo
