[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20025 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/20025 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 @gatorsmile @liufengdb Anything else? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86508/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)** for PR 20025 at commit [`883deb2`](https://github.com/apache/spark/commit/883deb2309a7581178c8de8b53d92ba309f6b4b9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)** for PR 20025 at commit [`883deb2`](https://github.com/apache/spark/commit/883deb2309a7581178c8de8b53d92ba309f6b4b9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86370/testReport)** for PR 20025 at commit [`5b3c06f`](https://github.com/apache/spark/commit/5b3c06f07f017c9a7b1dc51a4461fbf1c63ac350). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86370/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86370/testReport)** for PR 20025 at commit [`5b3c06f`](https://github.com/apache/spark/commit/5b3c06f07f017c9a7b1dc51a4461fbf1c63ac350). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86349/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86349/testReport)** for PR 20025 at commit [`79fc11a`](https://github.com/apache/spark/commit/79fc11ad58136f3f254b68d8fa3b2d8d1dd1942d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86349/testReport)** for PR 20025 at commit [`79fc11a`](https://github.com/apache/spark/commit/79fc11ad58136f3f254b68d8fa3b2d8d1dd1942d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20025 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/20025 @gatorsmile @felixcheung I left one comment, otherwise lgtm. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 @cloud-fan @gatorsmile @liufengdb @felixcheung @srowen @vanzin Is anybody could make further contact and discuss this PR? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86231/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86231/testReport)** for PR 20025 at commit [`79fc11a`](https://github.com/apache/spark/commit/79fc11ad58136f3f254b68d8fa3b2d8d1dd1942d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86231/testReport)** for PR 20025 at commit [`79fc11a`](https://github.com/apache/spark/commit/79fc11ad58136f3f254b68d8fa3b2d8d1dd1942d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86167/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86167/testReport)** for PR 20025 at commit [`162a93f`](https://github.com/apache/spark/commit/162a93f727d8c3b29461b0bbb3d40e880675f63b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86167/testReport)** for PR 20025 at commit [`162a93f`](https://github.com/apache/spark/commit/162a93f727d8c3b29461b0bbb3d40e880675f63b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 ping @liufengdb --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 ping gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 @gatorsmile What is your opinion about this? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/20025 My understanding is that the reflection was used because we might use a different version of hive then we didn't control what it was done inside the `super.init`. However, after we inlined the hive code, it is safe to call the `super.init` method. This is a cleaner way to fix the referred and other potential bugs, IMO. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 @rxin Could you please to review this? Thanks. In my opinion we can create a new or follow-up PR if refactor is necessary. This PR is to fix the bug about the Session Timeout Checker does not work currently. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 @liufengdb I think the class `SessionManager.java` is merged from Hive originally, and in Spark we redesigned it by adding `SparkSQLSessionManager.scala` with no affect to `SessionManager.java` : `val sparkSqlSessionManager = new SparkSQLSessionManager(hiveServer, sqlContext) setSuperField(this, "sessionManager", sparkSqlSessionManager)` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/20025 @zuotingbing I think all the code in SparkSQLSessionManager.scala should gone because they are just some reflection hacks. It is possible to call `super.init(hiveConf)` instead to get the session timeout checker and all other things start, isn't? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 Currently we do not call the `super.init(hiveConf)` in `SparkSQLSessionManager.init`, it means `SessionManager.init` which includes `createBackgroundOperationPool()` will not be called. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 Could you please merge this to Master? Thanks @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85299/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #85299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)** for PR 20025 at commit [`34b7680`](https://github.com/apache/spark/commit/34b7680dfd915449087b8f5541c682b02df5dfbc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #85299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)** for PR 20025 at commit [`34b7680`](https://github.com/apache/spark/commit/34b7680dfd915449087b8f5541c682b02df5dfbc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20025 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
