Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86660/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86660/testReport)**
for PR 20224 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86660/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/247/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86655/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86655/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86655/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/244/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86638/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86638/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86636/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86636/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86632/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86631/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86632/testReport)**
for PR 20224 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86631/testReport)**
for PR 20224 at commit
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated again to address @cloud-fan 's comments: removed unneeded test case
and added a bit more comments.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86638/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/229/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86636/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/227/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated again. Addressed @viirya 's comments:
1. added comments to explain where this codegen stage ID is used
2. moved an assertion message to a comment.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86632/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/224/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20224
LGTM with minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20224
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86631/testReport)**
for PR 20224 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86627/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86627/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20224
LGTM, pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86627/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/222/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20224
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86612/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86612 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86612/testReport)**
for PR 20224 at commit
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated the PR:
1. addressed @cloud-fan 's comment to make sure the `codegenStageId` is
properly copied in transformations after `CollapseCodegenStages`. Added a new
unit test case for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/211/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86612 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86612/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
BTW, inspired by @cloud-fan 's comment, here's an example of the codegen
stage IDs when scalar subqueries are involved:
```scala
val sub = "(select sum(id) from range(5))"
val
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
also ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86521/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86521/testReport)**
for PR 20224 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86521/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/133/
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86515/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86515/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86516/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86516/testReport)**
for PR 20224 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86516/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/128/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #86515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86515/testReport)**
for PR 20224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/127/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
I've updated the PR addressing @gatorsmile 's comments: moved the new
utility code to `WholeStageCodegenId` object and added a new test case in
`HiveExplainSuite`.
ping @gatorsmile
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks @gatorsmile ! Will add a new test case in `HiveExplainSuite`.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20224
Overall, the proposal looks good to me. We need a test case in
`HiveExplainSuite`
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20224
As high level comment, to add IDs helps performance/error diagnosis in
production environments. I strongly support to always enable this.
Let me look at technical detail later.
---
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks for your comments, @viirya !
I'd say only having (1) and (2) makes it much less useful than having all
3, but it's still useful in its own for helping people understand exactly
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20224
> Would you (@kiszk and @maropu ) agree that at least having both (1) and
(2) is a good idea?
Without (3), is this still useful if we only have (1) and (2)? It may not
much useful if only
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks for your comments and questions, @kiszk and @maropu !
Let me address them in a couple of separate points.
**tl;dr**
On top of my original proposal in the PR
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20224
We always need to turn on this? It seems this is debug info for developers?
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20224
I totally agree to add unique ID. This is because all of the generated code
by whole-stage codegen has the same class name. It makes us hard to debug in a
production environment.
On the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85940/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #85940 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85940/testReport)**
for PR 20224 at commit
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
One comment as to using `ThreadLocal[Integer]` for keeping track of the
IDs: I did have an alternative implementation of this PR that declares
`WholeStageCodegenExec` as:
```scala
case
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20224
**[Test build #85940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85940/testReport)**
for PR 20224 at commit
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85938/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20224
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
92 matches
Mail list logo
