[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20519 I hope we can go with the error message one for now if we are all fine here. Will keep my eyes on JIRA and mailing list and check if similar issues are raised again .. ---

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-13 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20519 I'm ok with either approach; the stdout approach can still suffer from people doing crazy things in their customizations (like messing with what stdout is), but at that point I'm ok with not

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-12 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20519 >Can't we just go with the error message for now? Sure, but before we decide not to fix, did you see my comment

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20519 For the change itself in this PR. it looks a overkill .. Can't we just go with the error message for now? --- - To

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-10 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20519 >yea but we can't simply flush and ignore the stdout specifically from sitecustomize unless we define a kind of an additional protocol like this because we can't simply distinguish if the

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20519 Hm .. yea but we can't simply flush and ignore the stdout specifically from sitecustomize unless we define a kind of an additional protocol like this because we can't simply distinguish if the

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20519 I am not yet fully sure about how sitecustomize fills some bytes to stdout but I believe it doesn't always happen because at least we have it for Python coverage -

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87267/ Test PASSed. ---

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87267/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87267/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87262/ Test FAILed. ---

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87262/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87262/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87173/ Test PASSed. ---

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87173/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87173/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87171/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87171/ Test FAILed. ---

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20519 **[Test build #87171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87171/testReport)** for PR 20519 at commit

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20519 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-06 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20519 >corner case described in the JIRA I don't have a good feeling for how often people use python site customizations. I did encounter a real life case that caused the failure described

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20519 Isn't it too a invasive change to deal with a corner case described in the JIRA .. ? Did I maybe miss something? --- - To

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20519: [Spark-23240][python] Don't let python site customizatio...

2018-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20519 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional