[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20726 Btw, I think the title should be `[SQL]` instead of `[CORE]`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20726 LGTM with one trivial doc point. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87980/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87980/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87979/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87979/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87975/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87975/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87980/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87970/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87979/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20726 ^ known flaky test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87970/testReport)** for PR 20726 at commit [`a27957a`](https://github.com/apache/spark/commit/a27957a4781ef06c6b3aa40fbd6bc22d45217460). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20726 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87973/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87973/testReport)** for PR 20726 at commit [`ccadd45`](https://github.com/apache/spark/commit/ccadd459d90c7f5b3de777b983a3f1c6b64171ce). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87975/testReport)** for PR 20726 at commit [`f637476`](https://github.com/apache/spark/commit/f637476e85731cb149a8935a91d1c3f344e3cca2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/20726 Looks good to me other than a minor point on the private `readerFactories` val. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87973/testReport)** for PR 20726 at commit [`ccadd45`](https://github.com/apache/spark/commit/ccadd459d90c7f5b3de777b983a3f1c6b64171ce). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20726 LGTM except one comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20726 I think both failures don't reflect a deeper problem: * The first was because columnar batch scans silently shortcutted around the readerFactories lazy val, and would error out if it were called. I fixed this, but the resulting code is kinda messy, so let me know if you see a better way to do it. * The second was a bit of fragile logic, basically measuring which streaming metric interval every data source method gets called in. The change does indeed move reader factory creation from addBatch to queryPlanning; this is expected and non-problematic. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87970/testReport)** for PR 20726 at commit [`a27957a`](https://github.com/apache/spark/commit/a27957a4781ef06c6b3aa40fbd6bc22d45217460). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87924/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87924/testReport)** for PR 20726 at commit [`efb8397`](https://github.com/apache/spark/commit/efb839759ddc1df1eec1b14500eebe5e4ca903c5). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20726 **[Test build #87924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87924/testReport)** for PR 20726 at commit [`efb8397`](https://github.com/apache/spark/commit/efb839759ddc1df1eec1b14500eebe5e4ca903c5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20726 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20726 @cloud-fan @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
