[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20820 This is good to have, but we should follow `BroadcastHashJoinExec` and make the implementation more structured. e.g. `codegenInner`, `codegenOuter`, etc. ---

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-03-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20820 @hvanhovell @cloud-fan Is it worth a try? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20820: [SPARK-23676][SQL]Support left join codegen in SortMerge...

2018-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20820 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional