[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-11-07 Thread koeninger
Github user koeninger commented on the issue:

https://github.com/apache/spark/pull/21038
  
@SehanRathnayake Kafka is designed for at most one consumer per partition 
per consumer group at any given point in time, 
https://kafka.apache.org/documentation/#design_consumerposition  
Spark already manages creating a consumer per partition for the consumer 
group associated with a stream.
If you have a valid use case for running multiple Spark applications with 
the same consumer group, please explain it in a jira, not discussion of a pull 
request that has already been merged.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-11-07 Thread SehanRathnayake
Github user SehanRathnayake commented on the issue:

https://github.com/apache/spark/pull/21038
  
I think  "This is fundamentally not correct, different apps should use 
different consumer group" statement is wrong. .According to Kafka Having 
consumers as part of the same consumer group means providing the “competing 
consumers” pattern with whom the messages from topic partitions are spread 
across the members of the group. 
It seams Spark-Fafka cannot support this for now


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-17 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/21038
  
Thanks @koeninger for the review.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-17 Thread koeninger
Github user koeninger commented on the issue:

https://github.com/apache/spark/pull/21038
  
Seems like that should help address the confusion.  Merging to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-17 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/21038
  
Ping @koeninger , would you please help to review again. Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21038
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21038
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89230/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21038
  
**[Test build #89230 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89230/testReport)**
 for PR 21038 at commit 
[`a7770e9`](https://github.com/apache/spark/commit/a7770e9b853e5357f737922dcd019058823b6812).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21038
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2234/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21038
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21038: [SPARK-22968][DStream] Throw an exception on partition r...

2018-04-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21038
  
**[Test build #89230 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89230/testReport)**
 for PR 21038 at commit 
[`a7770e9`](https://github.com/apache/spark/commit/a7770e9b853e5357f737922dcd019058823b6812).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org