[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21217 @mgaido91 No problem. Please submit the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21217 if it's ok for you @viirya , I am submitting a PR for this then. I'll specify in the description that the credit should be given to @jamesthomp but this can be done also by the committer when eventually merging it I think. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21217 Thanks @jamesthomp for you work. When we pick this up, I think we can still give the credit of the work to you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 I would be glad for @viirya or @mgaido91 to pick this up from me. It sounds like the remaining work is to move the test from `SQLQuerySuite` into `AnalysisSuite`, but I'm not certain how to easily do that as the form of the tests in `AnalysisSuite` is a bit different. Feel free to take my code and push it up onto another branch, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21217 Thanks for pinging me @HyukjinKwon . I can take it over too, let me know. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21217 @HyukjinKwon thanks for pinging me. I'd wait for others to take over this first, if no one does, I can do it later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21217 Can anyone take over this then? cc @kiszk, @mgaido91 and @viirya as well FYI. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21217 Ping once more since this can be merged into Spark 3.0, @robert3005 . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21217 Hi, @robert3005 I know you deleted the branch, but could you try this once more? At this time, I can review and merge this if this is ready. Also, can we have a test in `AnalysisSuite` instead of `SQLQuerySuite`? cc @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93181/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #93181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93181/testReport)** for PR 21217 at commit [`f31cd56`](https://github.com/apache/spark/commit/f31cd56e754cc88d597ccbd9086317985c890e12). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #93181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93181/testReport)** for PR 21217 at commit [`f31cd56`](https://github.com/apache/spark/commit/f31cd56e754cc88d597ccbd9086317985c890e12). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 @HyukjinKwon - I have resolved the conflict with the docs changes. Please let me know if any additional changes are required. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93059/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #93059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93059/testReport)** for PR 21217 at commit [`6db67e4`](https://github.com/apache/spark/commit/6db67e4619a05357bfe693e315b732f6bca6e5ea). * This patch **fails due to an unknown error code, -9**. * This patch **does not merge cleanly**. * This patch adds the following public classes _(experimental)_: * ` class ImplicitTypeCasts(conf: SQLConf) extends TypeCoercionRule ` * `case class StringToTimestampWithoutTimezone(child: Expression, timeZoneId: Option[String] = None)` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #93059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93059/testReport)** for PR 21217 at commit [`6db67e4`](https://github.com/apache/spark/commit/6db67e4619a05357bfe693e315b732f6bca6e5ea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21217 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21217 @jamesthomp, mind updating this please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90194/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90194/testReport)** for PR 21217 at commit [`6db67e4`](https://github.com/apache/spark/commit/6db67e4619a05357bfe693e315b732f6bca6e5ea). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` class ImplicitTypeCasts(conf: SQLConf) extends TypeCoercionRule ` * `case class StringToTimestampWithoutTimezone(child: Expression, timeZoneId: Option[String] = None)` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90194/testReport)** for PR 21217 at commit [`6db67e4`](https://github.com/apache/spark/commit/6db67e4619a05357bfe693e315b732f6bca6e5ea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user jamesthomp commented on the issue: https://github.com/apache/spark/pull/21217 @gatorsmile - I have added a note to the migration guide. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21217 @jamesthomp Could you document the behavior change in the migration guide? https://github.com/apache/spark/blame/master/docs/sql-programming-guide.md#L1802 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90138/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90138/testReport)** for PR 21217 at commit [`662dd2e`](https://github.com/apache/spark/commit/662dd2e1dcd9de2ada87811e116b420f138cfa13). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90138/testReport)** for PR 21217 at commit [`662dd2e`](https://github.com/apache/spark/commit/662dd2e1dcd9de2ada87811e116b420f138cfa13). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21217 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90081/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90081/testReport)** for PR 21217 at commit [`662dd2e`](https://github.com/apache/spark/commit/662dd2e1dcd9de2ada87811e116b420f138cfa13). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21217 **[Test build #90081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90081/testReport)** for PR 21217 at commit [`662dd2e`](https://github.com/apache/spark/commit/662dd2e1dcd9de2ada87811e116b420f138cfa13). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21217 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21217 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
