Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21221
@mccheah When you merged the code, could you also leave the comments about
which branches you did the merge?
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21221
For the other reviewers, this was merged to master (not 2.4)
---
-
To unsubscribe, e-mail:
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/21221
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21221
Thanks, I think this looks good. With a prior +1 from @felixcheung and
@squito I'm going to merge this now. Let us know if there are any further
concerns and we can follow up.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95801/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #95801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95801/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #95801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95801/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95776/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #95776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95776/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #95776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95776/testReport)**
for PR 21221 at commit
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21221
@edwinalu - this can merge now that Spark 2.4's release branch has been
cut, but there's conflicting files now. Can we clear the conflicts and then we
can merge this?
---
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21221
We're going to delay on merging this until after the 2.4 branch is cut. We
can include this in Spark 2.5.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94865/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94865 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94865/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94865 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94865/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94842/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94842/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94842/testReport)**
for PR 21221 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94757/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94757/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94759/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94759/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94759/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94757/testReport)**
for PR 21221 at commit
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21221
@edwinalu I think this is almost ready, can you fix merge conflicts?
@squito @felixcheung any other comments?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94715/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94715/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94715/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94240/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94240/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #94240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94240/testReport)**
for PR 21221 at commit
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/21221
@mccheah and @squito , thanks for reviewing and commenting, and sorry for
the delay. I'll reply and update this weekend.
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93570/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #93570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93570/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93557/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #93557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93557/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #93570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93570/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #93557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93557/testReport)**
for PR 21221 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
sorry this week has been really busy, and I'm on vacation next week, so a
little more delay before I get further on this. (though anybody else is
welcome to review and merge this, I feel pretty
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92490/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92490/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92490/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92488/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92488/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92488/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92275/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92275/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #92275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92275/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91983 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91983/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91846/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91846 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91846/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91846 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91846/testReport)**
for PR 21221 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91811/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91811/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91804/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91804 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91804/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91811/testReport)**
for PR 21221 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91802/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91802/testReport)**
for PR 21221 at commit
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/21221
@squito , I've replaced PeakMemoryMetrics with just an Array[Long], and
added a custom serializer an deserializer for it.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91804 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91804/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91802/testReport)**
for PR 21221 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
well, I think you should change the way PeakExecutorMetrics gets converted
to json, so that it uses a name from the relevant `MetricGetter`. You should
be able to customize the way it gets
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/21221
@squito For PeakMemoryMetrics in api.scala, changing to the array gives
REST API output of:
"peakMemoryMetrics" : {
"metrics" : [ 755008624, 100519936, 0, 0, 47962185, 0,
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/21221
@squito , I'm modifying ExecutorMetrics to take in the metrics array --
this will be easier for tests where we pass in set values, and seems fine for
the actual code. It will check that the length
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91642/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91642/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91642 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91642/testReport)**
for PR 21221 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21221
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21221
probably need to be rebased
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91424/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91424 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91424/testReport)**
for PR 21221 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #91424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91424/testReport)**
for PR 21221 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90613/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #90613 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90613/testReport)**
for PR 21221 at commit
1 - 100 of 113 matches
Mail list logo
