[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21300 Thanks for your confirmation. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/21300 this is ok to me since it's turned off by default --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21300 See the JIRA; this still looks like a bug fix and seems OK for back port to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21300 @koeninger Not all the committers check the JIRA regularly. For such a big backport PR, we need to check the impact and sometimes even we need to change the implementation to reduce the risk and impacts. Thus, it would be always good to let the others double check and review it instead of directly merging it. cc @zsxwing @srowen @rxin. Could you double check the PRs and confirm whether the risk is low for backporting it to 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/21300 @gatorsmile this is identical to the original PR which was reviewed by @srowen and discussion on the jira to backport it had not raised any objections since April --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21300 @koeninger We need a peer review before merging such a PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21300 cc @zsxwing --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/21300 Merging to branch-2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90513/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21300 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21300 **[Test build #90513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90513/testReport)** for PR 21300 at commit [`84648e0`](https://github.com/apache/spark/commit/84648e0222330fd3bc43ce214689b66795efdffe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3145/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21300 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21300: [SPARK-24067][BACKPORT-2.3][STREAMING][KAFKA] Allow non-...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21300 **[Test build #90513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90513/testReport)** for PR 21300 at commit [`84648e0`](https://github.com/apache/spark/commit/84648e0222330fd3bc43ce214689b66795efdffe). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
