[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[rxin]

Github user rxin commented on the issue:

https://github.com/apache/spark/pull/21433
  
Yea we can add this back easily.

On Tue, Sep 11, 2018 at 12:50 PM Sean Owen  wrote:

> Given lack of certainty, and that's this is small and easy to add back in
> a different form, and the fact that 2.4 is quickly teeing up, let me 
revert
> this for now. We can proceed with a different approach in a new PR.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[srowen]

Github user srowen commented on the issue:

https://github.com/apache/spark/pull/21433
  
Given lack of certainty, and that's this is small and easy to add back in a 
different form, and the fact that 2.4 is quickly teeing up, let me revert this 
for now. We can proceed with a different approach in a new PR.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[gatorsmile]

Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/21433
  
@michaelmior Since Spark 2.4 is branch cut, this PR still needs more 
review. I would revert this PR from branch 2.4 and master first. We can discuss 
the conf and implementation in the master branch. The preferred conf name is 
`spark.eventLog.callsite.longForm.enabled`. Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[michaelmior]

Github user michaelmior commented on the issue:

https://github.com/apache/spark/pull/21433
  
@gatorsmile @cloud-fan I'll just go with a boolean config as there really 
is no need for more than two options and this simplifies things quite a bit.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[michaelmior]

Github user michaelmior commented on the issue:

https://github.com/apache/spark/pull/21433
  
Thanks @srowen!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[srowen]

Github user srowen commented on the issue:

https://github.com/apache/spark/pull/21433
  
Merged to master


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4206 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4206/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4206 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4206/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4205 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4205/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).
 * This patch **fails PySpark unit tests**.
 * This patch **does not merge cleanly**.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4205 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4205/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[michaelmior]

Github user michaelmior commented on the issue:

https://github.com/apache/spark/pull/21433
  
@srowen Yes, I don't expect it will be widely used but I've personally 
found it helpful in some performance debugging and it's a fairly low impact 
change. I was just hoping to avoid having to keep applying this patch and doing 
my own build of Spark in the future :)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4203 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4203/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4203 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4203/testReport)**
 for PR 21433 at commit 
[`245181a`](https://github.com/apache/spark/commit/245181a6ebb03b4f394097297ae245705aaf9b0f).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[michaelmior]

Github user michaelmior commented on the issue:

https://github.com/apache/spark/pull/21433
  
Rebased on top of master. The [failing test 
](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4200/testReport/org.apache.spark.sql.hive/HiveExternalCatalogVersionsSuite/_It_is_not_a_test_it_is_a_sbt_testing_SuiteSelector_/)
 is unrelated.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4200 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4200/testReport)**
 for PR 21433 at commit 
[`9800d2e`](https://github.com/apache/spark/commit/9800d2eddf100d32223e2ef3cae1ad3279368454).
 * This patch **fails Spark unit tests**.
 * This patch **does not merge cleanly**.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[srowen]

Github user srowen commented on the issue:

https://github.com/apache/spark/pull/21433
  
Although maybe not widely used, I could see allowing control of this via an 
undocumented param


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21433
  
**[Test build #4200 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4200/testReport)**
 for PR 21433 at commit 
[`9800d2e`](https://github.com/apache/spark/commit/9800d2eddf100d32223e2ef3cae1ad3279368454).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21433
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[michaelmior]

Github user michaelmior commented on the issue:

https://github.com/apache/spark/pull/21433
  
Done!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[kiszk]

Github user kiszk commented on the issue:

https://github.com/apache/spark/pull/21433
  
Could you please add the description for this PR?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21433
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21433: [SPARK-23820][CORE] Enable use of long form of callsite ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21433
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org