Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21442
I opened a new PR at https://github.com/apache/spark/pull/21797/files Will
work on the test issue there. Thanks.
---
-
To
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21442
@dbtsai can you open a new PR? thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
This hasn't get any test pass even once. The test is broken by this commit:
Before:
```
$ build/sbt "~sql/test-only *SQLQueryTestSuite -- -z
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21442
Seems like a related test failure? cc @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93143/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93143/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
LGTM. The test failure is not related to this PR.
Thanks! Merged to master.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93143/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21442
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93136/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93136 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93136/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93130/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93130/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93136 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93136/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93130/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21442
@HyukjinKwon thanks for bringing this to my attention. @gatorsmile I
thought the bug is found by this PR, and not in this PR. This PR is blocked
until SPARK-24443 is addressed. I'll unblocck this PR
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93076/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93076/testReport)**
for PR 21442 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21442
@dbtsai I think this PR can be unblocked if we only turn `In` to `EqualTo`
if the `list` is not a `ListQuery`. We can work around the type mismatch
problem for now.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
@HyukjinKwon Currently, in my opinion, the highest priority PRs include
Parquet nested column pruning
(https://github.com/apache/spark/pull/21320/files), new built-in avro,
high-order
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
Also, the root cause of getting a lot of pings is that we somehow started
to block the Jenkins build for some old PRs. Probably I missed some threads in
dev mailing list but I still don't know
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
Of course, the time and priority matter but there are pending PRs queued up
due to the time and priority matter so far.
Shall we check the PRs and see if there are important ones for
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
If you want to help this, we should ping the reviewers/committers based on
the priority of these PRs. Also, we should not trigger the pings within a short
period. Please reduce the size of the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
I am not blindly triggering the test. I skimmed and only re-triggered tests
some PRs while I am skimming stale PRs.
For "ok to test", I haven't also blindly re-triggered. I did where
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
@HyukjinKwon Thank you for trying to trigger the tests but it will not help
if you got many pings within one hour. To save the resource, we need to do more
investigation before blindly
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
Also, see the stale PRs and see what we have delayed to take a look. Please
consider partly this is what we should have checked and reviewed earlier,
and/or partly authors haven't updated their
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
This should get updated, right? I should give a ping here anyway. I wonder
why triggering retesting so matters for some PRs.
Probably, you are mostly talking about "ok to test" that I
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
@HyukjinKwon All the involved reviewers will get a ping. This is annoying
to see many pings within one hour, right? My suggestion is to read the comments
before triggering the test
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
@gatorsmile, can I just see if it the build passes against the latest build?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21442
@HyukjinKwon The code has a bug. Please read the discussion before you
trigger the retest.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/990/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #93076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93076/testReport)**
for PR 21442 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91258/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91258/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3670/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21442
LGTM, pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91258/testReport)**
for PR 21442 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21442
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91243/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91243/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3657/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91243/testReport)**
for PR 21442 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21442
@maropu I didn't do a full performance benchmark. I believe the performance
gain can be from predicate pushdown when only one element in the set. This can
be a lot.
I forgot which one, I
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21442
Thanks for the work. One question; do we have actual performance changes
with/without this pr?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91218/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91218/testReport)**
for PR 21442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3636/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3634/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21442
**[Test build #91218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91218/testReport)**
for PR 21442 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21442
+@cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
75 matches
Mail list logo
