[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-11-11 Thread wangtao605
Github user wangtao605 commented on the issue: https://github.com/apache/spark/pull/21766 > @wangtao605 Do you mind documenting our behavior in our Spark SQL doc? Yes, it's ok. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-11-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21766 @wangtao605 Do you mind documenting our behavior in our Spark SQL doc? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-17 Thread wangtao605
Github user wangtao605 commented on the issue: https://github.com/apache/spark/pull/21766 @rxin In order to support sql syntax better and align SQL standards. I think it is worth to add a numeric type as an alias of decimal. ---

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-17 Thread wangtao605
Github user wangtao605 commented on the issue: https://github.com/apache/spark/pull/21766 @dmateusp Actually i think "Numeric" has no essential difference with "Decimal". May be just have it as an alias is better,i will add some tests if you agree. ---

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21766 Why did you need this change? Given it's very difficult to revert the change (or introduce a proper numeric type if ever needed in the future), I would not merge this pull request unless there are

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-15 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21766 Just checked out the PR, ```scala scala> spark.sql("SELECT CAST(1 as NUMERIC)") res0: org.apache.spark.sql.DataFrame = [CAST(1 AS DECIMAL(10,0)): decimal(10,0)] scala>

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21766 aha, I didn't know that and postgresql also uses them interchangeably, too. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21766 They are not exactly the same in ANSI SQL, although MS SQL Server looks like use them interchangeably.

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21766 @gatorsmile Is it worth adding a numeric type as an alias of decimal? Both types seems to be in the SQL standard and some dbms (e.g., postgresql and sql server) can parse both. @wangtao605 Can

[GitHub] spark issue #21766: [SPARK-24803][SQL] add support for numeric

2018-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21766 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional