Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21931
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95190/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95190 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95190/testReport)**
for PR 21931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95190/testReport)**
for PR 21931 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95157/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95157/testReport)**
for PR 21931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95157/testReport)**
for PR 21931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95154/testReport)**
for PR 21931 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95154/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95154/testReport)**
for PR 21931 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95107/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95107/testReport)**
for PR 21931 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21931
**[Test build #95107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95107/testReport)**
for PR 21931 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21931
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21931
Minor comments. LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM, cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
@kiszk , @cloud-fan
I was on vacation some time ago, I'm sorry to delayed reply.
I have update it, Can you help to review it again if your have some times.
thanks.
---
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
@kiszk ,I'm not sure how much the maximum is set, and the size of 1G is the
maximum value accepted by numBuckets. Of course, buckets is the memory of 8G.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
Does this work when we set `30` into the parameter? I am afraid that
several arrays with size `0x7fff` are allocated.
---
-
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21931
cc: @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
@kiszk, Thank you for your suggestion. I have update it. Can you review it
again if you have some time. thanks.
---
-
To
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21931
@maropu, The test results show that we can make a configuration parameter
for the capacity of fast hash. Currently capacity of our fast hash is related
to the length of the recorded data. so
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21931
What does the benchmark result suggest? The result should be `1048576` by
default?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21931
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21931
@heary-cao, thanks! I am a bot who has found some folks who might be able
to help with the review:@rxin, @cloud-fan and @yhuai
---
36 matches
Mail list logo
