[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/22216
  
I see. Let me think again. I'd close this for now. Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread hvanhovell
Github user hvanhovell commented on the issue:

https://github.com/apache/spark/pull/22216
  
I think the use of global state and a thread local is far more hacky and 
probably is slower.

The only clean solution I see here is to pass the lambda values around 
using the input row. I am not saying that this easy.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22216
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22216
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95203/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22216
  
**[Test build #95203 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95203/testReport)**
 for PR 22216 at commit 
[`c27121b`](https://github.com/apache/spark/commit/c27121b8743fad106cd5cd2ce33d22814856ec9c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22216
  
**[Test build #95203 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95203/testReport)**
 for PR 22216 at commit 
[`c27121b`](https://github.com/apache/spark/commit/c27121b8743fad106cd5cd2ce33d22814856ec9c).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/22216
  
cc @cloud-fan 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22216
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22216: [SPARK-25223][SQL] Use a map to store values for NamedLa...

2018-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22216
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2523/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org