Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96800/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96800/testReport)**
for PR 22316 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
I'm merging this. Last change is comment change and lint / unidoc check
passed.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96800/testReport)**
for PR 22316 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96759/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96759/testReport)**
for PR 22316 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
@cloud-fan Thank you for the suggestion. I did it in this way.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96759/testReport)**
for PR 22316 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22316
One safe change is to not use the `lit` function, but to do a manual
pattern match and still use `Literal.apply`. We can investigate
`Literal.create` in a followup
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96520/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96520 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96520/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96520 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96520/testReport)**
for PR 22316 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Can you just investigate if there's behaviour change about decimal
precision? If there is, can you add a simple test if that's a better behaviour?
If that's not a better behaviour, let's
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
> LGTM if the decimal precision concern from @HyukjinKwon is addressed.
@HyukjinKwon Do you expect special tests for decimals?
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22316
LGTM if the decimal precision concern from @HyukjinKwon is addressed.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96420/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96420/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96420/testReport)**
for PR 22316 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96409/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96409/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96409 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96409/testReport)**
for PR 22316 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22316
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96404/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96404/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #96404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96404/testReport)**
for PR 22316 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
I could check it by myself but it would take some time since I'm kind of
busy for now :-(
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
@HyukjinKwon @maropu @jaceklaskowski Please, take a look at this PR one
more time.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
LGTM otherwise
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
@gatorsmile Do you have any objections for this approach?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Seems fine to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95829/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95829/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95829/testReport)**
for PR 22316 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Branch is cut out. Let's target 3.0.0
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
At least @gatorsmile and @cloud-fan, WDYT?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Looks good but I wonder if all guys are happy with that involved in the
previous PR.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22316
@HyukjinKwon May I ask you to look at the PR. Is there anything which
blocks the PR for now?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95631/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95631/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95631/testReport)**
for PR 22316 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95592/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95592/testReport)**
for PR 22316 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95592/testReport)**
for PR 22316 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95590/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95590/testReport)**
for PR 22316 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Yup I prefer this way
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95590/testReport)**
for PR 22316 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
61 matches
Mail list logo
