[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22960 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98566/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98566/testReport)** for PR 22960 at commit [`24933a9`](https://github.com/apache/spark/commit/24933a9e457fe6b0110de0aa27bc9eaa9dc00fb9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98566/testReport)** for PR 22960 at commit [`24933a9`](https://github.com/apache/spark/commit/24933a9e457fe6b0110de0aa27bc9eaa9dc00fb9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98542/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98542/testReport)** for PR 22960 at commit [`1d3a31b`](https://github.com/apache/spark/commit/1d3a31b478622a8e76dfeef0f71973aa71730859). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22960
Ur, maybe, I'm not clear to the point. The refactoring scope of this PR is
limited to the new tests here.
```
test("from_csv uses DDL strings for defining a schema - java")
test("roundtrip to_csv -> from_csv")
test("roundtrip from_csv -> to_csv")
test("infers schemas of a CSV string and pass to to from_csv")
test("Support to_csv in SQL")
test("Support from_csv in SQL")
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22960 Yes. It would be great if we do that in this PR. When I did the similar thing for ORC (`port tests from Parquet to ORC`, `port from old ORC to new ORC`). I received the same comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98542/testReport)** for PR 22960 at commit [`1d3a31b`](https://github.com/apache/spark/commit/1d3a31b478622a8e76dfeef0f71973aa71730859). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22960 > Sorry, but Porting seems to be not the best way to do this. I saw a bunch of common code in `Csv`/`JsonExpressionsSuite`, `Csv`/`JsonFunctionsSuite` and `Csv`/`JsonSuite`. I just didn't want to overcomplicate the tests especially in the case when there are small differences. So, passing functions (with inputs and expected result) to template functions will not make them easy to read. > Could you refactor this by introducing new test helper functions? In any case, I will try that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98531/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98531/testReport)** for PR 22960 at commit [`d863402`](https://github.com/apache/spark/commit/d863402db4ef0165c7a1b9da1eb6a4151d162741). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98530/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98530/testReport)** for PR 22960 at commit [`606be67`](https://github.com/apache/spark/commit/606be67e8a422a0e650c2dc29bd724be9b80e411). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98531/testReport)** for PR 22960 at commit [`d863402`](https://github.com/apache/spark/commit/d863402db4ef0165c7a1b9da1eb6a4151d162741). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22960 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98530/testReport)** for PR 22960 at commit [`606be67`](https://github.com/apache/spark/commit/606be67e8a422a0e650c2dc29bd724be9b80e411). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
