Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9463#discussion_r44738061
--- Diff: R/pkg/R/DataFrame.R ---
@@ -837,23 +836,23 @@ setMethod("first",
take(x, 1)
})
-# toRDD
-#
-#
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156293314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156293312
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156293076
**[Test build #45801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45801/consoleFull)**
for PR 9463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156291948
**[Test build #45803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45803/consoleFull)**
for PR 9463 at commit
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9463#discussion_r44738175
--- Diff: R/pkg/R/DataFrame.R ---
@@ -837,23 +836,23 @@ setMethod("first",
take(x, 1)
})
-# toRDD
-#
-#
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156284515
Sorry for the delay. I found one minor problem with `toRDD` -- otherwise
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156289995
**[Test build #45801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45801/consoleFull)**
for PR 9463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156289725
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156289622
thanks for catching that, I did some test I suspect they are caused by
generics.R, so removing those.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156289745
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156290401
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156316598
Thanks @felixcheung - Looks good now. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156316295
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156316297
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-156279440
Could we push this, at least to master? that would really help dev running
lintr for a much more manageable volume of warnings/errors
---
If your project is set up
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-155598069
@shivaram ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-155599129
Sorry this slipped through. Will look at this tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-154274259
@shivaram ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153917663
@felixcheung Thanks for taking a shot at this. Can we remove the `@export`
from these functions as well ? They are not exported in the public API so it
seems thats not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153939317
**[Test build #45092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45092/consoleFull)**
for PR 9463 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153942273
@yu-iskw btw, these are two other false positives that you might want to
follow up with lintr:
```
R/pkg/inst/tests/test_sparkSQL.R:907:53: style:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153942677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153942676
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153942605
**[Test build #45092 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45092/consoleFull)**
for PR 9463 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153938433
Done. they won't do anything because of `@noRd`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153938890
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153938912
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153648555
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153648581
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/9463
[SPARK-11263][SPARKR] lintr Throws Warnings on Commented Code in
Documentation
Clean out hundreds of `style: Commented code should be removed.` from lintr
Like these:
```
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153649411
**[Test build #45012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45012/consoleFull)**
for PR 9463 at commit
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153819461
In my research, lintr have a bug of `commented_code_linter`.
I just reported the bug to the lintr community.
https://github.com/jimhester/lintr/issues/118
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153811238
LGTM
`@noRd` is a good idea. We still have other commented code warnings, right?
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153821649
@yu-iskw yes, there are roughly a dozen "commented code" warnings left but
they are mostly false positives, like the example you quoted.
At this point I'd rather
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9463#issuecomment-153660981
**[Test build #45012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45012/consoleFull)**
for PR 9463 at commit
37 matches
Mail list logo
