[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-160133764 I'd defer to @mengxr on this one for final approval but yes that's definitely what I had in mind. It's nice that you refactored add and subtract together --- If your

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159442668 **[Test build #46644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46644/consoleFull)** for PR 9916 at commit

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159464499 **[Test build #46644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46644/consoleFull)** for PR 9916 at commit

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159464613 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159464611 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-23 Thread ehsanmok
GitHub user ehsanmok opened a pull request: https://github.com/apache/spark/pull/9916 [SPARK-11826][MLlib] Reimplement add() and subtract() methods @srowen Could you please check this when you have time? You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159060584 **[Test build #46551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46551/consoleFull)** for PR 9916 at commit

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159062241 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159062232 **[Test build #46551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46551/consoleFull)** for PR 9916 at commit

[GitHub] spark pull request: [SPARK-11826][MLlib] Reimplement add() and sub...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9916#issuecomment-159062240 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your