[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2016-04-25 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-214437787 @HyukjinKwon I will continue working on this and finish the work this week. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2016-04-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-214143879 @huaxingao Do you mind If I submit a PR based on this if you are not working on this? (It looks it has been inactive for few months!) --- If your project is set

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2016-01-11 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-170701187 @yhuai Sorry for the late reply. I waited for my coworker Luciano to come back from vacation today to check with him about his DB2 docker test status. He has

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-19 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-166033287 @yhuai JDBCSuite uses H2 database. It seems that for char(n) data type, either H2 database doesn't pad, or the H2 JDBC driver already trims the empty space for

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-166058803 I guess we can try to add a docker test. Can you try to add one in

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-16 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-165297054 Can you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164680145 @andrewor14 Thanks a lot for your comment. I will change to what you suggested. In the same method, case DecimalConversion has the similar code. Shall I

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread 3ourroom
Github user 3ourroom commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164680307 NAVER - http://www.naver.com/ 3ourr...@naver.com 님께 보내신 메일 이 다음과 같은 이유로

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164945607 Jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164946337 **[Test build #47763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47763/consoleFull)** for PR 10262 at commit

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164966501 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164966495 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164966108 **[Test build #47763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47763/consoleFull)** for PR 10262 at commit

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-164583283 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10262#discussion_r47570429 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -422,7 +422,14 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-10 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/10262 [SPARK-12270][SQL]remove empty space after getString from database {code} conn.prepareStatement( "create table people (name char(32)").executeUpdate()

[GitHub] spark pull request: [SPARK-12270][SQL]remove empty space after get...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10262#issuecomment-163812129 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your