[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10386#issuecomment-168077826 @huaxingao can you close this pull request now https://github.com/apache/spark/pull/10468 has been merged? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-22 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10386#issuecomment-166565039 Please add tests by referring #10409. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10386#discussion_r48210518 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -288,6 +295,12 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10386#discussion_r48210212 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -269,6 +269,13 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10386#discussion_r48210318 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -288,6 +295,12 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-21 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10386#issuecomment-166468363 Great work and I left some comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10386#discussion_r48210742 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -288,6 +295,12 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10386#issuecomment-165894557 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SQL]add filter (IN, AND, OR)

2015-12-18 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/10386 [SPARK-12409][SQL]add filter (IN, AND, OR) push filters IN, ADD, OR to JDBC layer. You can merge this pull request into a Git repository by running: $ git pull