Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49128371
QA results for PR 1259:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49208726
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49209789
Thanks. Merging this. We can fix the serialization error logging in a
separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49117675
QA tests have started for PR 1259. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16699/consoleFull
---
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49117816
Updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49121954
QA results for PR 1259:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49123160
@andrewor14 PTAL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-49123305
QA tests have started for PR 1259. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16710/consoleFull
---
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48871282
@andrewor14 the task id is not logged twice. One is TID, which is used to
correlate with the executors (because executors only know about TID's), and the
other is the task
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48925260
Task IDâ is globally unqiue, index is unique within a stage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48834061
I brought this up to date. @andrewor14 can you take a look at this? I'd
want to merge this quickly so I can submit my other scheduler patches too.
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48834107
QA tests have started for PR 1259. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16600/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48835596
QA results for PR 1259:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859597
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -490,19 +488,19 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859634
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -429,9 +425,11 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859639
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -521,14 +519,13 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859645
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -429,9 +425,11 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859653
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -570,19 +561,17 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1259#discussion_r14859650
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -536,23 +533,17 @@ private[spark] class TaskSetManager(
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48848292
Hi @rxin, I took a pass over the patch and the changes mostly look good. On
a higher level point, I notice that we log this pattern `0.0:4.0 (TID 4 ...)`
quite often,
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-48859674
If we actually want people to get information out of all those numbers, can
we consider using a human readable format such as `Task(stageId = 1, taskId =
5, attempt =
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/1259
[SPARK-2317] Improve task logging.
We use TID to indicate task logging. However, TID itself does not capture
stage or retries, making it harder to correlate with the application itself.
This pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47443715
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47443712
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47444257
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16233/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47444256
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445053
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445051
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445106
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445104
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445143
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445144
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16235/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1259#issuecomment-47445598
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
34 matches
Mail list logo
