Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49865796
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17032/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49873447
QA results for PR 1399:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49959455
We will continue to improve the migration guide, but this LGTM for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49959642
@liancheng are you ready to merge this? Can you remove [WIP] if so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15213826
--- Diff: docs/sql-programming-guide.md ---
@@ -573,4 +572,170 @@ prefixed with a tick (`'`). Implicit conversions
turn these symbols into expres
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49715371
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16959/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49721444
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15222777
--- Diff: bin/beeline ---
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49749099
QA tests have started for PR 1399. This patch DID NOT merge cleanly!
brView progress:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49753393
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16968/consoleFull
---
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49754843
Hey @pwendell, thanks for the detailed comments and review. I believe the
last a few commits have addressed all issues brought up. I rebased this PR to
the most recent
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49759732
QA results for PR 1399:br- This patch FAILED unit tests.brbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49763828
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49814629
The build failure was due to mima configuration, just disabled mima for
`hive-thriftserver`.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49814756
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16997/consoleFull
---
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49816076
I only looked at this from a packaging/scripts perspective. But LGTM in
that regard.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49819658
QA results for PR 1399:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15266402
--- Diff: sql/hive-thriftserver/pom.xml ---
@@ -0,0 +1,75 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+ ~ Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15267219
--- Diff: sql/hive-thriftserver/pom.xml ---
@@ -0,0 +1,75 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+ ~ Licensed to the Apache Software
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15155941
--- Diff: bin/spark-sql ---
@@ -0,0 +1,81 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15155947
--- Diff: assembly/pom.xml ---
@@ -162,6 +162,11 @@
artifactIdspark-hive_${scala.binary.version}/artifactId
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15155961
--- Diff: docs/sql-programming-guide.md ---
@@ -573,4 +572,170 @@ prefixed with a tick (`'`). Implicit conversions
turn these symbols into expres
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49548923
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16871/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49548926
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49549992
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16873/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49550014
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49550656
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16874/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49550677
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49551156
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16875/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49553961
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49569446
QA tests have started for PR 1399. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16890/consoleFull
---
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154620
--- Diff: assembly/pom.xml ---
@@ -162,6 +162,11 @@
artifactIdspark-hive_${scala.binary.version}/artifactId
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154735
--- Diff: bin/spark-sql ---
@@ -0,0 +1,81 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154749
--- Diff: bin/beeline ---
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154767
--- Diff: docs/sql-programming-guide.md ---
@@ -573,4 +572,170 @@ prefixed with a tick (`'`). Implicit conversions
turn these symbols into expres
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154792
--- Diff: docs/sql-programming-guide.md ---
@@ -573,4 +572,170 @@ prefixed with a tick (`'`). Implicit conversions
turn these symbols into expres
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15154977
--- Diff: sql/hive-thriftserver/pom.xml ---
@@ -0,0 +1,75 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+ ~ Licensed to the Apache Software
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15155042
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
---
@@ -0,0 +1,345 @@
+/*
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1399#issuecomment-49572019
QA results for PR 1399:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r15045195
--- Diff: sbin/start-thriftserver.sh ---
@@ -0,0 +1,24 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1399#discussion_r14987086
--- Diff: sbin/start-thriftserver.sh ---
@@ -0,0 +1,24 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF)
41 matches
Mail list logo
