[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1986#issuecomment-53618367 Hi @scwf, given that there is another PR that supersedes this one, would you mind closing this? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53618778 @tnachen, would you mind closing this PR since there is another outstanding one with a simpler fix? (#2161) This JIRA has many open PRs that try to solve the same

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-27 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53619460 @andrewor14 np! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-27 Thread tnachen
Github user tnachen closed the pull request at: https://github.com/apache/spark/pull/2103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-27 Thread scwf
Github user scwf closed the pull request at: https://github.com/apache/spark/pull/1986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-26 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1986#discussion_r16700565 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -111,48 +113,43 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-26 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1986#discussion_r16703237 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -96,18 +99,39 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-26 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1986#discussion_r16703504 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -96,18 +99,39 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-26 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/1986#discussion_r16709350 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -111,48 +113,43 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-26 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/1986#discussion_r16719740 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -96,18 +99,39 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-25 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2103#discussion_r16645606 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -29,9 +28,12 @@ import

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-25 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53241843 Hey it is not clear how you are fixing the stated bug. It would be great if you could explain or somehow exclude the code cleanups from the PR. --- If your project

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2103#discussion_r16692779 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -111,48 +113,39 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-25 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2103#discussion_r16696990 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -111,48 +113,39 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread tnachen
GitHub user tnachen opened a pull request: https://github.com/apache/spark/pull/2103 [SPARK-2608] fix executor backend launch commond over mesos mode based on @scwf patch, rebased on master and have a fix to actually get it to work. It failed to run with a single mesos

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53146097 @pwendell take a look at the new fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53146211 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19099/consoleFull) for PR 2103 at commit

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53147354 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19099/consoleFull) for PR 2103 at commit

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53151568 what's the diff with my pr https://github.com/apache/spark/pull/1986? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53156348 My last commit is the diff in this pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-23 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/2103#issuecomment-53156411 Btw this is still not ideal IMO since it computes the class path in the scheduler side and assumes all slave executors after unzip has the same setup. --- If your

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-18 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/1986#issuecomment-52561076 Is there any difference between this PR than the one you closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-18 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1986#issuecomment-52590358 @tnachen, no actually, i just merge with the new master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-16 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/1986 [SPARK-2608] fix executor backend launch commond over mesos mode https://issues.apache.org/jira/browse/SPARK-2608 This is the updated version of https://github.com/apache/spark/pull/1513

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-16 Thread scwf
Github user scwf closed the pull request at: https://github.com/apache/spark/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1986#issuecomment-52396653 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51566443 QA results for PR 1513:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-08 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51674336 @pwendell , can you verify this pr? thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-07 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51563959 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51564211 QA tests have started for PR 1513. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18185/consoleFull ---

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51297961 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51298388 QA tests have started for PR 1513. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18005/consoleFull ---

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51298628 QA results for PR 1513:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51298744 It looks it's not failing unit tests but can't even compile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51300042 it's becaude [SPARK-2260] update Command.scala, i will fix it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-06 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51423993 @pwendell i have fixed compile error, can you retest this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-03 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-51011413 @pwendell , i can not see the failed unit test info, can you give me some infer --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-02 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-50974423 I was considering a similar fix but I wasnt sure if computing all the class paths and options here where the task is submitted is safe versus in spark-class Where the

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-50851919 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-50852097 QA tests have started for PR 1513. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17650/consoleFull ---

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-50852319 QA results for PR 1513:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-07-21 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/1513 [SPARK-2608] fix executor backend launch commond over mesos mode mesos scheduler backend use spark-class/spark-executor to launch executor backend, this will lead to problems: 1 when set

[GitHub] spark pull request: [SPARK-2608] fix executor backend launch commo...

2014-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1513#issuecomment-49627746 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your