[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-17 Thread adrian-wang
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-17 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55867500 maybe 2407 is better, I'll close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55699441 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20368/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2355#discussion_r17585678 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala --- @@ -113,30 +113,32 @@ private[hive] case class

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2355#discussion_r17585758 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala --- @@ -113,30 +113,32 @@ private[hive] case class

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55722541 Hi @liancheng I have created another PR(PR #2407 ) on this issue, offering another solution. Please let me know which solution do you guys prefer here. --- If your

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55722631 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20380/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55722729 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20380/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55723585 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20381/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55731253 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20381/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55576959 I have changed the way to fix the problem here, keeping most of the original logics. @marmbrus --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55577018 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55577211 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20334/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55582984 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20334/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55590580 Sorry for the missings here... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55594998 @chenghao-intel This is not so complex since it is not GenericUDF, but simple UDF with limited types. So we do not need to call those here. --- If your project is

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55595044 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20339/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55605670 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20339/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
GitHub user adrian-wang reopened a pull request: https://github.com/apache/spark/pull/2355 [SPARK-3485][SQL] should check parameter type when look for constructors In hiveUdfs, we get constructors of primitivetypes by find a constructor which takes only one parameter. This is very

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55693733 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55694052 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20368/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55517166 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20299/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55514020 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/102/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55515521 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/102/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-13 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55515801 Have my code rebased, should be able to merge cleanly! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55515819 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20299/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread adrian-wang
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/2355 [SPARK-3485][SQL] should check parameter type when look for constructors In hiveUdfs, we get constructors of primitivetypes by find a constructor which takes only one parameter. This is very

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55248253 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20150/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55256940 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20150/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55257928 failure is in streaming. Actually this is a potential problem if hive decide to add a constructor for timstampwritable with one parameters exactly, other than

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55258048 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55259016 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20155/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55271703 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20155/consoleFull) for PR 2355 at commit

[GitHub] spark pull request: [SPARK-3485][SQL] should check parameter type ...

2014-09-11 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2355#issuecomment-55277871 The last failure was `recovery with file input stream` in `CheckpointSuite` and this time, the failure is in `block generator throttling` in `NetworkReceiverSuite`.