Github user anantasty commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61222153
@davies @mengxr Just made the suggested changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61222418
[Test build #22598 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22598/consoleFull)
for PR 2952 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19653295
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,24 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19653338
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61228643
[Test build #22598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22598/consoleFull)
for PR 2952 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61228648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user anantasty commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19683664
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19684029
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61305357
@mengxr I think it's ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anantasty commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61305691
@mengxr @davies Thanks for the time and guidance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61306151
[Test build #22618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22618/consoleFull)
for PR 2952 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61314835
[Test build #22618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22618/consoleFull)
for PR 2952 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61314842
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user anantasty commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61316422
The URL shows 0 failures I am not sure why it says the tests fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61341643
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61341766
[Test build #22658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22658/consoleFull)
for PR 2952 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61347393
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61347387
[Test build #22658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22658/consoleFull)
for PR 2952 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-61352555
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user anantasty commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19653043
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19581470
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19581493
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19581517
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,40 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user anantasty commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19585582
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user anantasty commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19585598
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,40 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19588505
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,40 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19588522
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60794001
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60794164
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60794739
[Test build #22364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22364/consoleFull)
for PR 2952 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60795382
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60795375
[Test build #22364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22364/consoleFull)
for PR 2952 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60625545
@anantasty Could you also update the doc in
`https://github.com/apache/spark/blob/master/docs/mllib-feature-extraction.md`?
Thanks!
---
If your project is set up for
Github user anantasty commented on the pull request:
https://github.com/apache/spark/pull/2952#issuecomment-60687518
@mengxr I updated the example code as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19451852
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,28 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19451869
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,28 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19451872
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,28 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19451976
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,28 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19452204
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19452346
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,28 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19453782
--- Diff: docs/mllib-feature-extraction.md ---
@@ -162,6 +162,38 @@ for((synonym, cosineSimilarity) - synonyms) {
}
{% endhighlight %}
/div
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19453785
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2952#discussion_r19453784
--- Diff: examples/src/main/python/mllib/word2vec.py ---
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
44 matches
Mail list logo
