Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2741
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58820340
It is probably good to add, but maybe in a separate PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58820370
I'm merging this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58808996
LGTM. Is it worth to add `val UTF8 = Charset.forName("UTF-8")` into `object
Utils`?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58707547
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21598/consoleFull)
for PR 2741 at commit
[`b5366cc`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58707551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58699925
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21598/consoleFull)
for PR 2741 at commit
[`b5366cc`](https://github.com/ap
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58699131
> Should specify charset when converting between bytes and String, or Spark
always assumes the environment uses UTF8?
It looks like `String.getBytes` uses the p
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58628876
Changes lgtm overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58621671
It's really helpful :+1: Just a small question: Should specify charset when
converting between bytes and String, or Spark always assumes the environment
uses UTF8?
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58602118
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21561/consoleFull)
for PR 2741 at commit
[`cef18b3`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58602120
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58598221
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21561/consoleFull)
for PR 2741 at commit
[`cef18b3`](https://github.com/ap
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2741#discussion_r18683461
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala ---
@@ -913,8 +911,12 @@ private[nio] class ConnectionManager(
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2741#issuecomment-58597882
Thanks to @patmcdonough for suggesting this. /cc @rxin for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/2741
[SPARK-3887] Send stracktrace in ConnectionManager error replies
When reporting that a remote error occurred, the ConnectionManager should
also log the stacktrace of the remote exception. This PR
16 matches
Mail list logo
