[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/2935 [SPARK-4082] remove unnecessary broadcast for conf We already broadcast the task (RDD and closure) itself, so some small data used in RDD or closure do not needed to be broadcasted explicitly any

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60452576 [Test build #22167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22167/consoleFull) for PR 2935 at commit

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60452971 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60452968 [Test build #22167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22167/consoleFull) for PR 2935 at commit

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60460198 Due to a Hadoop thread-safety issue in `Configuration`'s constructor, we need to hold a lock in any code that might call `new Configuration()` on the executor. We

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60460256 BTW, maybe you meant to link to https://issues.apache.org/jira/browse/SPARK-4083? I think this is a duplicate of https://issues.apache.org/jira/browse/SPARK-2585

[GitHub] spark pull request: [SPARK-4082] remove unnecessary broadcast for ...

2014-10-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2935#issuecomment-60460447 Also, adding our own synchronizing wrapper will let us roll back some of the complexity introduced by #2684 for ensuring thread-safety, since each task will get its