[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-28 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2954#issuecomment-60757729 @WangTaoTheTonic I would rather not see pull requests that don't really add any value. I realize this is cleanup, but I would rather see these included in something

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-28 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2954#issuecomment-60763871 OK I see. 发自我的 iPhone 在 2014年10月28日,21:51,Tom Graves notificati...@github.com 写道: @WangTaoTheTonic I would

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-27 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/spark/pull/2954 [SPARK-4095][YARN][Minor]extract val isLaunchingDriver in ClientBase Instead of checking if `args.userClass` is null repeatedly, we extract it to an global val as in `ApplicationMaster`.

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2954#issuecomment-60554332 [Test build #22278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22278/consoleFull) for PR 2954 at commit

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2954#issuecomment-60558127 [Test build #22278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22278/consoleFull) for PR 2954 at commit

[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...

2014-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2954#issuecomment-60558131 Test PASSed. Refer to this link for build results (access rights to CI server needed):