Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22275938
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -35,6 +35,15 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22275955
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -55,19 +64,31 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22275969
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -55,19 +64,31 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22275976
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -55,19 +64,31 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68115893
Just a couple of more comments for making the name more consistent with
existing ones. Otherwise I approve of the how the `registerGauge` works now.
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68119029
[Test build #24827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24827/consoleFull)
for PR 3466 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68119033
Hi TD, thanks a lot for your comments, I just change the code style as you
suggested, also add one more metrics `totalProcessedRecords`, would you mind
reviewing this
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68121187
LGTM. Merging this. Thanks @jerryshao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68121546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68121543
[Test build #24827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24827/consoleFull)
for PR 3466 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22266250
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22267558
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68087844
[Test build #24808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24808/consoleFull)
for PR 3466 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68090373
[Test build #24808 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24808/consoleFull)
for PR 3466 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68090374
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22241115
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -62,6 +62,14 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22241227
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -62,6 +62,14 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22241231
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -62,6 +62,14 @@ private[streaming] class StreamingSource(ssc:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22241246
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -70,4 +78,8 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68015296
Thanks a lot TD for your comments, I will factor out the old code and fix
the above issues you mentioned.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68017979
[Test build #24751 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24751/consoleFull)
for PR 3466 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68018004
Hey TD, I've addressed the problem you mentioned in this way, I'm not is
this what you want, would you mind taking a look at it ? Thanks a lot.
---
If your project
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22243982
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22244053
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22245026
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68023279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-68023274
[Test build #24751 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24751/consoleFull)
for PR 3466 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r22246102
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -28,46 +28,58 @@ private[streaming] class StreamingSource(ssc:
Github user maasg commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r20924293
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -70,4 +78,14 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r20931831
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -70,4 +78,14 @@ private[streaming] class StreamingSource(ssc:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3466#discussion_r20932324
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingSource.scala ---
@@ -70,4 +78,14 @@ private[streaming] class StreamingSource(ssc:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64749125
[Test build #23913 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23913/consoleFull)
for PR 3466 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64753876
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64753870
[Test build #23913 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23913/consoleFull)
for PR 3466 at commit
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/3466
[SPARK-4537][Streaming] Expand StreamingSource to add more metrics
Add `processingDelay`, `schedulingDelay` and `totalDelay` for the last
completed batch. Add `lastReceivedBatchRecords` and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64509682
[Test build #23868 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23868/consoleFull)
for PR 3466 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64514695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3466#issuecomment-64514692
[Test build #23868 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23868/consoleFull)
for PR 3466 at commit
39 matches
Mail list logo
