Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127404523
@namma Thanks for taking a look! If there are other options, types of
feature importance, or other metrics which are important for your use, please
make JIRAs and pin
Github user namma commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36129080
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1113,4 +1114,77 @@ private[ml] object RandomForest extends Logging {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7838
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127376362
Merging with master and branch-1.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127373943
[Test build #1317 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1317/console)
for PR 7838 at commit
[`72a167a`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127363605
[Test build #1317 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1317/consoleFull)
for PR 7838 at commit
[`72a167a`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127362626
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127362522
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127362492
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127356954
[Test build #39563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39563/console)
for PR 7838 at commit
[`86cea5f`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127357028
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127349482
[Test build #39563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39563/consoleFull)
for PR 7838 at commit
[`86cea5f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127348744
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127348685
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127347623
@yanboliang Thank you for taking a look! I just fixed some merge issues.
After tests pass, I'll merge this with master.
---
If your project is set up for it, you
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36105696
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -98,7 +95,8 @@ final class RandomForestClassifier(ove
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127117188
Looks good except some trivial issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36054846
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -98,7 +95,8 @@ final class RandomForestClassifier(ov
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36054229
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala
---
@@ -30,7 +30,7 @@ import
org.apache.spark.mllib.tree.model.
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36054220
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -32,7 +29,7 @@ import
org.apache.spark.mllib.tree.m
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127063868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127063468
[Test build #39438 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39438/console)
for PR 7838 at commit
[`1442c2b`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127059360
[Test build #39438 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39438/consoleFull)
for PR 7838 at commit
[`1442c2b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127058196
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127058154
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127057765
@yanboliang Would you mind checking those updates? I think that should be
it (and it worked locally). That will be Java-friendly.
---
If your project is set up for
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-127052370
I just realized the Map is not Java-friendly. I might modify this to store
numFeatures in the model so that we can use Vector instead.
---
If your project is set up
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126998709
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7838#discussion_r36040523
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1113,4 +1114,77 @@ private[ml] object RandomForest extends Logging
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126960802
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126960785
[Test build #39385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39385/console)
for PR 7838 at commit
[`610dd57`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958712
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958705
[Test build #39384 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39384/console)
for PR 7838 at commit
[`cd86e18`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958642
[Test build #39385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39385/consoleFull)
for PR 7838 at commit
[`610dd57`](https://gith
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958547
OK that should finally do it. @namma Would you mind taking a final look?
Thank you!
@yanboliang If you have a chance, that would be valuable as well. Thanks!
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958512
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7838#issuecomment-126958506
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
37 matches
Mail list logo
