[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-04 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72810144 Thanks! I have merged this. On Tue, Feb 3, 2015 at 11:30 PM, UCB AMPLab notificati...@github.com wrote: Test PASSed. Refer to this link for build

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72785026 Also could could update the python API as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72784927 Please add unit tests for this behavior! It should be in StreamingContextSuite. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72796748 [Test build #26726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26726/consoleFull) for PR 4171 at commit

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72797695 LGTM, will merge when tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72803094 [Test build #26726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26726/consoleFull) for PR 4171 at commit

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-72803099 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-71159820 [Test build #26002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26002/consoleFull) for PR 4171 at commit

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-71159823 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-71172693 Yeah, it seems good to propagate the `Boolean` return value from `waiter` here, or else there's no way to distinguish timeout from non-timeout. And yes it seems like it

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-22 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/4171 [SPARK-5379][Streaming] Add awaitTerminationOrTimeout Added `awaitTerminationOrTimeout` to return if the waiting time elapsed: * `true` if it's stopped. * `false` if the waiting time elapsed

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-71155123 [Test build #26002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26002/consoleFull) for PR 4171 at commit

[GitHub] spark pull request: [SPARK-5379][Streaming] Add awaitTerminationOr...

2015-01-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/4171#issuecomment-71154979 cc @tdas, @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this