[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72577494 [Test build #26574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26574/consoleFull) for PR 4301 at commit

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23976526 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -149,6 +165,18 @@ private[clustering] object

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23976829 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -149,6 +165,18 @@ private[clustering] object

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72587034 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23980652 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -149,6 +165,18 @@ private[clustering] object

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941409 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -149,6 +165,18 @@ private[clustering] object

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941402 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -70,6 +72,17 @@ class PowerIterationClustering

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941396 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -43,10 +43,12 @@ class PowerIterationClusteringModel(

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941407 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -149,6 +165,18 @@ private[clustering] object

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941399 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -70,6 +72,17 @@ class PowerIterationClustering

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4301#discussion_r23941398 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -70,6 +72,17 @@ class PowerIterationClustering

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72586516 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72586512 [Test build #26574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26574/consoleFull) for PR 4301 at commit

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72421316 [Test build #26494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26494/consoleFull) for PR 4301 at commit

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72421323 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72364545 Looks like the test failed on an unrelated unit test. Please test it again. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72364465 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72364459 [Test build #26473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26473/consoleFull) for PR 4301 at commit

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72362826 [Test build #26473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26473/consoleFull) for PR 4301 at commit

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/4301 [SPARK-5512][Mllib] Run the PIC algorithm with initial vector suggected by the PIC paper As suggested by the paper of Power Iteration Clustering, it is useful to set the initial vector v0 as the

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72373979 @viirya If that works better than a randomized vector in general, we can replace the current initialization. We set it to a random vector to guarantee that if it far from

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72414811 @mengxr I think it is better to keep both and leave it as an option users can switch. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-5512][Mllib] Run the PIC algorithm with...

2015-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4301#issuecomment-72415114 [Test build #26494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26494/consoleFull) for PR 4301 at commit