Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4997
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-86206368
@yanboliang LGTM merging into master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85974043
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85974027
[Test build #29160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29160/consoleFull)
for PR 4997 at commit
[`102f498`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85936478
[Test build #29160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29160/consoleFull)
for PR 4997 at commit
[`102f498`](https://githu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85829732
@yanboliang It looks fine to me, except for the intercept issue (sorry!)
and for doc tests. Could you please add doc tests for LassoWithSGD,
RidgeRegressionWithSGD usi
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4997#discussion_r27088281
--- Diff: python/pyspark/mllib/regression.py ---
@@ -142,7 +149,8 @@ class LinearRegressionWithSGD(object):
@classmethod
def train(cl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85561467
[Test build #29090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29090/consoleFull)
for PR 4997 at commit
[`1fb7b4f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85561527
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-85511976
[Test build #29090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29090/consoleFull)
for PR 4997 at commit
[`1fb7b4f`](https://githu
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4997#discussion_r27030181
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -111,9 +111,11 @@ private[python] class PythonMLLibAPI extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4997#discussion_r26953234
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -111,9 +111,11 @@ private[python] class PythonMLLibAPI extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84821465
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84821414
[Test build #28978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28978/consoleFull)
for PR 4997 at commit
[`de5ecbc`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84788358
[Test build #28978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28978/consoleFull)
for PR 4997 at commit
[`de5ecbc`](https://githu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84200346
Let's also add setIntercept. Also, in addition to setFeatureScaling being
private, we do not need to expose optimizer.setUpdater for the 2 algorithms you
listed becaus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4997#discussion_r26874628
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -133,15 +137,23 @@ private[python] class PythonMLLibAPI extends
S
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84139723
@yanboliang `setFeatureScaling` is not a public method. We were a little
hesitated to expose it. Shall we only add `validateData` in this PR?
---
If your project is set u
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-84051013
@jkbradley @mengxr Can you review this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-78473162
[Test build #28509 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28509/consoleFull)
for PR 4997 at commit
[`2dff3df`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-78473172
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4997#issuecomment-78463236
[Test build #28509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28509/consoleFull)
for PR 4997 at commit
[`2dff3df`](https://githu
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/4997
[SPARK-6256] [MLlib] MLlib Python API parity check for regression
MLlib Python API parity check for Regression, major disparities list
following:
LinearRegressionWithSGD
setValid
23 matches
Mail list logo
