Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-90256298
Should this be in 1.3.2? Seems like people are hitting it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89338628
@zsxwing this looks fine, though a little funky because we send
TaskScheduler and all of its pointers through Akka, though I don't see another
simpler alternative.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89387258
LGTM merging this into master 1.3 thanks. The new solution looks much
better!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89369342
[Test build #29677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29677/consoleFull)
for PR 5306 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89369375
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89338682
[Test build #29677 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29677/consoleFull)
for PR 5306 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27713951
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-89150977
@zsxwing this looks fine, though a little funky because we send
`TaskScheduler` and all of its pointers through Akka, though I don't see
another simpler alternative.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27714088
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -356,11 +356,17 @@ class SparkContext(config: SparkConf) extends Logging
with
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27714109
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88388558
[Test build #29525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29525/consoleFull)
for PR 5306 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88388576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88370940
[Test build #29525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29525/consoleFull)
for PR 5306 at commit
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5306
[SPARK-6640][Core] Fix the race condition of creating HeartbeatReceiver and
retrieving HeartbeatReceiver
This PR moved the code of creating `HeartbeatReceiver` above the code of
creating
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27573736
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27575792
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88512610
[Test build #29546 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29546/consoleFull)
for PR 5306 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88540218
[Test build #29546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29546/consoleFull)
for PR 5306 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88540236
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27628404
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5306#discussion_r27619143
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -71,12 +75,22 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext,
22 matches
Mail list logo
