Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34847593
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34849488
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillMerger.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34850864
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34847659
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34849233
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSortDataFormat.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6444#discussion_r34848070
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120666382
Looks like this was merged but GitHub didn't auto-close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/6444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120247145
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120247172
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120247317
[Test build #37018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37018/consoleFull)
for PR 6444 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120267531
[Test build #37018 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37018/console)
for PR 6444 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120267551
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120273429
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120273150
[Test build #37015 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37015/console)
for PR 6444 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120551712
Thanks - I'm going to merge this and review more next week. We can address
feedbacks incrementally for this one.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120551103
[Test build #1041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1041/console)
for PR 6444 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120441448
[Test build #37045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37045/console)
for PR 6444 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120441503
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120424914
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120424936
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120424385
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120425739
[Test build #37045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37045/consoleFull)
for PR 6444 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120487145
This is failing tests because my change to SparkPlanTest introduced
multiple overloaded methods with default arguments, which isn't legal in Scala.
Let me see if I
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120498973
[Test build #37051 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37051/consoleFull)
for PR 6444 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120498211
I hacked around the default args. issue by removing many overloaded methods
in SparkPlanTest. Please take a look.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120498337
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120498407
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120534235
[Test build #1041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1041/consoleFull)
for PR 6444 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120534721
LGTM, The last failure is caused by an known flaky test, I think this one
is good to go.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120532373
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6444#issuecomment-120532338
[Test build #37051 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37051/console)
for PR 6444 at commit
32 matches
Mail list logo
