Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1430#issuecomment-49127540
The code looks good to me.
I am thinking if we could merge the ConstantFolding NullPropagation and
make it `transformExpressionsUp` , since they kind of rely
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1430#issuecomment-49128331
See the discussion at #1428.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1430#issuecomment-49202491
Merging in master branch-1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1430#issuecomment-49203889
Actually only master. There is a conflict in branch-1.0 that I will leave
it intact for now.
---
If your project is set up for it, you can reply to this email and have
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/1430
[SQL] Cleaned up ConstantFolding slightly.
Moved couple rules out of NullPropagation and added more comments.
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1430#issuecomment-49125944
QA tests have started for PR 1430. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16714/consoleFull
---
