[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user willb commented on the pull request:
https://github.com/apache/spark/pull/1323#issuecomment-55345856
Hi @jkbradley; thanks for taking a look. Here are the warnings as I see
them when compiling tests on the immediate ancestor of my branch, which is
56e009d (I'm running on OS X 10.9 in this case):
```
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:38:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] This can be achieved by adding the import clause 'import
scala.language.postfixOps'
[warn] or by setting the compiler option -language:postfixOps.
[warn] See the Scala docs for value scala.language.postfixOps for a
discussion
[warn] why the feature should be explicitly enabled.
[warn] implicit val defaultTimeout = timeout(1 millis)
[warn] ^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:99:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] preGCTester.assertCleanup()(timeout(1000 millis))
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:117:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] preGCTester.assertCleanup()(timeout(1000 millis))
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:134:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] preGCTester.assertCleanup()(timeout(1000 millis))
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:156:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] preGCTester.assertCleanup()(timeout(1000 millis))
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:187:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] preGCTester.assertCleanup()(timeout(1000 millis))
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala:290:
postfix operator millis should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] eventually(waitTimeout, interval(100 millis)) {
[warn]^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala:138:
postfix operator seconds should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] failAfter(10 seconds) {
[warn] ^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala:174:
postfix operator seconds should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] failAfter(10 seconds) {
[warn] ^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ui/UISuite.scala:42:
postfix operator seconds should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] eventually(timeout(10 seconds), interval(50 milliseconds)) {
[warn] ^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ui/UISuite.scala:42:
postfix operator milliseconds should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] eventually(timeout(10 seconds), interval(50 milliseconds)) {
[warn] ^
[warn]
/Users/willb/Documents/src/scala/alternate-spark/core/src/test/scala/org/apache/spark/ui/UISuite.scala:56:
postfix operator seconds should be enabled
[warn] by making the implicit value scala.language.postfixOps visible.
[warn] eventually(timeout(10 seconds), interval(50 milliseconds)) {
[warn] ^
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55347991 Hi @wllib can you comment on #1330? What is the difference between that patch and this, and which is the better approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user willb commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55351655 Hey @andrewor14, thanks for the reply. First off, I absolutely agree with @srowen's comment on #1330 that `import`s (not compiler flags) are the right way to handle enabling these language features. It looks to me like `SpanSugar` pulls in `postfixOps` -- and that it's the only thing in those files that uses `postfixOps`. (I guess having both `SpanSugar` and `postfixOps` imported at toplevel was causing some implicit resolution confusion?) In any case, the approach in #1330 is probably the way to go since explicitly importing `postfixOps` seems unnecessary and removing the compiler flag is a good idea. Thanks again for taking a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user willb closed the pull request at: https://github.com/apache/spark/pull/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55352231 I see, thanks for your patch anyway! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55194405 @willb Hi, I was asked to take a look at this. I tried the current master + this PR merged with master, and I did not see much difference in warnings (or any warnings about postfixOps). Could you please show the warnings, and info which might indicate the system/setup which produces the warnings? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-53340472 @willb @witgo What is the difference between your patches? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user willb commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51378794 Can someone take a look at this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51068459 QA tests have started for PR 1323. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17854/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51069490 Related work #1330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51076281 QA results for PR 1323:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17854/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-48329998 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16407/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix postfixOps warnings in the test suite
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-48329997 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
