[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-12-03 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-65404868 Thank you very much. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-12-03 Thread haosdent
Github user haosdent closed the pull request at: https://github.com/apache/spark/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-12-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-65164456 Thanks for working on this! I think this will be a really useful addition. However, with the new external data sources api that is part of 1.2, I think it might be

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-54694754 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-07-30 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-50693874 Hey @javadba, sorry I didn't see this earlier. I think for sure we want to add some HBase utility functions in Spark, but exactly what functionality is still unclear...

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-07-16 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-49133737 Hi, the referenced PR Spark-1416 includes the following comment by @MLnick: But looking at the HBase PR you referenced, I don't see the value of having that

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-05-31 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-44720047 ping @pwendell , 1.0 have been released~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-16 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-40618129 @pwendell Sorry for disturb you again. I saw 0.9.1 have been released, could you help me review this pull request again? Thank you very much. --- If your project is set

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-16 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-40620786 @haosdent the release I'm talking about is 1.0 which is currently being worked on --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-16 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-40622251 @pwendell Oh, sorry, I mistake what you say. The developing of Spark is quite fast --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-08 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39821743 @pwendell @marmbrus Could you help me review this pull request again? Thank you in advance. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-08 Thread BlackNiuza
Github user BlackNiuza commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39823084 This PR looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-08 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39824171 OK, I see. Thank you for your reply. :-) @pwendell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-07 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39718976 Quiet confused about `InputStreamsSuite`. I pass it in my local machine. And this is a case from `streaming` module, I think my pull request didn't have any related code

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-07 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39719475 The error from `https://travis-ci.org/apache/spark/builds/22424147`. I would trigger travis again after others fix that bug on master. --- If your project is set up for

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-04-06 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-39667634 @marmbrus @pwendell Could you help me review this pull request again? I have already add `saveAsHBaseTable(rdd: SchemaRDD ...)` method. Thank you in advance. --- If

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38881863 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-24 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38503577 Hi @haosdent, As patrick said, I think using a Schema RDD as the input would simplify this quite a bit and avoid the need to define your own custom column

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-24 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38523893 Let me know if you have any questions about how you could use this functionality. Thank you very much! :-) --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38391364 @haosdent could you add this to the SBT build as well? Look at how the other external projects work (e.g. twitter, mqtt, etc) --- If your project is set up for it, you

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-23 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10868441 --- Diff: external/hbase/pom.xml --- @@ -0,0 +1,92 @@ +?xml version=1.0 encoding=UTF-8? +!-- + ~ Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38392478 I looked at this a bit more closely. I'm definitely +1 on having some utility functions like this for writing to HBase. It seems a bit brittle to me that we

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-23 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38404602 I think a nicer way to do this would be to go through a SchemaRDD (which is a new feature recently merged into Spark) or even a Scala case class or Scala tuples.

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862584 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862585 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862614 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862631 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862643 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862647 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862656 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10862801 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38357324 @mridulm @tedyu I update the pull request as your advice. Could you help me review it again? Thank you very much. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10863200 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10863237 --- Diff: external/hbase/src/test/scala/org/apache/spark/nosql/hbase/HBaseSuite.scala --- @@ -0,0 +1,48 @@ +package org.apache.spark.nosql.hbase +

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10863248 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/SparkHBaseWriter.scala --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-22 Thread haosdent
Github user haosdent commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10863265 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38322773 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38324070 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10855690 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/194#discussion_r10855766 --- Diff: external/hbase/src/main/scala/org/apache/spark/nosql/hbase/HBaseUtils.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38329366 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13327/ --- If your project

[GitHub] spark pull request: SPARK-1127 Add spark-hbase.

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/194#issuecomment-38329364 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have