[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread JoshRosen 
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173292454
  
Jenkins, this is ok to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-17331
  
**[Test build #49791 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49791/consoleFull)**
 for PR 10848 at commit 
[`30cc932`](https://github.com/apache/spark/commit/30cc93246828da9728891f9ed6d65b26bcb888af).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173304304
  
LGTM.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173330653
  
Going to merge this in master. Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10848


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173329758
  
**[Test build #49791 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49791/consoleFull)**
 for PR 10848 at commit 
[`30cc932`](https://github.com/apache/spark/commit/30cc93246828da9728891f9ed6d65b26bcb888af).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173330527
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49791/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173330522
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread rajeshbalamohan 
GitHub user rajeshbalamohan opened a pull request:

https://github.com/apache/spark/pull/10848

SPARK-12925. [SQL]. Improve HiveInspectors.unwrap for StringObjectIns…

Text is in UTF-8 and converting it via "UTF8String.fromString" incurs 
decoding and encoding, which turns out to be expensive and redundant.  Profiler 
snapshot details is attached in the JIRA 
(ref:https://issues.apache.org/jira/secure/attachment/12783331/SPARK-12925_profiler_cpu_samples.png)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajeshbalamohan/spark SPARK-12925

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10848


commit 30cc93246828da9728891f9ed6d65b26bcb888af
Author: Rajesh Balamohan 
Date:   2016-01-20T12:15:56Z

SPARK-12925. [SQL]. Improve HiveInspectors.unwrap for 
StringObjectInspector.getPrimitiveWritableObject




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12925. [SQL]. Improve HiveInspectors.unw...

2016-01-20 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10848#issuecomment-173187383
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org