[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41243649 Looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41242752 Actually it's probably fixed here already: https://github.com/apache/spark/pull/516/files --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41238805 > Do you have time to fix that flaky test? Sure. I need some time to confirm my guess. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41215470 Thanks. I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41205563 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41205565 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14382/ --- If your project

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41195981 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41195959 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41195835 Thanks @zsxwing. I've restarted the test. Do you have time to fix that test? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41195792 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41135796 If I understand correctly, `SaveStageAndTaskInfo` in `SparkListenerSuite` lacks appropriate synchronization to guarantee memory visibility. That's why this test fails. -

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41131597 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41131598 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14360/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41129608 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41129604 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41129362 Mostly because java's HashMap is faster than Scala's ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41129348 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41129336 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-22 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/500 SPARK-1583: Fix a bug that using java.util.HashMap by mistake JIRA: https://issues.apache.org/jira/browse/SPARK-1583 Does anyone know why using `java.util.HashMap` rather than `mutable.HashM