Github user EugenCepoi commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57786084
@andrewor14 The trailing % came from a bad copy paste, nice catch :) Double
percent exists but was wrong in this case,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57786537
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21243/consoleFull)
for PR 2481 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57795374
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21243/consoleFull)
for PR 2481 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57795383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2481#discussion_r18406038
--- Diff: bin/compute-classpath.sh ---
@@ -27,8 +27,14 @@ FWDIR=$(cd `dirname $0`/..; pwd)
. $FWDIR/bin/load-spark-env.sh
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57823932
LGTM. I'm merging this into master and 1.1. Thanks @EugenCepoi!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user EugenCepoi commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57824300
@andrewor14 great! Glad to see it merged into master :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57826573
Ah yes I believe that's for the Spark daemons. We can merge that separately.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2481#discussion_r18190131
--- Diff: bin/compute-classpath.cmd ---
@@ -36,7 +36,13 @@ rem Load environment variables from conf\spark-env.cmd,
if it exists
if exist
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2481#discussion_r18190316
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -124,8 +117,8 @@ private[spark] class SparkSubmitArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2481#discussion_r18190367
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -86,20 +87,12 @@ private[spark] class SparkSubmitArguments(args:
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-57245137
Minor comments, but LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user EugenCepoi opened a pull request:
https://github.com/apache/spark/pull/2481
SPARK-2058: Overriding SPARK_HOME/conf with SPARK_CONF_DIR
Update of PR #997.
With this PR, setting SPARK_CONF_DIR overrides SPARK_HOME/conf (not only
spark-defaults.conf and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-56305629
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20630/consoleFull)
for PR 2481 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2481#issuecomment-56307689
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20630/consoleFull)
for PR 2481 at commit
16 matches
Mail list logo
