Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17456708
--- Diff: docs/monitoring.md ---
@@ -78,6 +78,13 @@ follows:
file system./td
/tr
tr
+tdspark.history.fs.logDirectory/td
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17456759
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -33,25 +35,33 @@ import scala.collection.mutable.HashMap
* All setter methods
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17456928
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1307,6 +1307,43 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17456978
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -30,6 +34,24 @@ class SparkConfSuite extends FunSuite with
LocalSparkContext {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17456959
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -297,4 +297,9 @@ class UtilsSuite extends FunSuite {
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r17457393
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -307,6 +317,27 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-5534
@witgo I like the idea of having all processes (HistoryServer, Master,
Worker etc.) read from the properties file in addition just `SparkSubmit`.
However, I don't
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-55353905
OK, I generally understand what you mean,I will re-implement the feature at
the weekend.
---
If your project is set up for it, you can reply to this email and have your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-53008877
@pwendell @andrewor14 could you guys take a look at this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-51746411
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18302/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-51749415
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50718143
QA results for PR 1256:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50718557
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50718809
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17564/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50725686
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50586734
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50586736
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17434/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50587212
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17435/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50590948
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50591525
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597062
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -33,25 +35,32 @@ import scala.collection.mutable.HashMap
* All setter methods in
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597124
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -291,7 +300,28 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597255
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -291,7 +300,28 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597441
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -369,12 +369,14 @@ private[spark] object Worker extends Logging {
def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597510
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1298,6 +1298,48 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597630
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1298,6 +1298,48 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597770
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -30,6 +32,23 @@ class SparkConfSuite extends FunSuite with
LocalSparkContext {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r15597856
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -30,6 +32,23 @@ class SparkConfSuite extends FunSuite with
LocalSparkContext {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50708611
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-50715208
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17555/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-49197007
QA tests have started for PR 1256. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16734/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1256#issuecomment-49211180
QA results for PR 1256:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brclass
32 matches
Mail list logo
