Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-50025677
+1 thanks @rahulsinghaliitd !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49874400
I've only used the sbt/sbt scalastyle target. I'm not sure if there is a
reason it wasn't implemented in maven. you could file a jira for it and get
comments from the
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49874426
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49874824
QA tests have started for PR 1094. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17034/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49889792
QA results for PR 1094:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49733427
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49733823
QA tests have started for PR 1094. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16962/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49733906
QA results for PR 1094:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49736022
Jenkins, this is okay to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49736019
@rahulsinghaliitd sorry for this dragging on I forgot to kick jenkins.
Looks like its complaining about scalastyle. Can you please update.
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49828457
@tgravescs No problem at all. Updated patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49830504
@tgravescs There does not seem to be a maven goal to check scalastyle,
isn't this something we want?
---
If your project is set up for it, you can reply to
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r15177387
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala
---
@@ -289,7 +289,7 @@ class ExecutorLauncher(args:
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r15206722
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala
---
@@ -289,7 +289,7 @@ class ExecutorLauncher(args:
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49572410
@tgravescs updated according to your comments and rebased to current HEAD
of master branch.
---
If your project is set up for it, you can reply to this email
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r15112301
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -114,7 +114,7 @@ class HistoryServer(
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49133859
@tgravescs updated according to your comments and rebased to current HEAD
of master branch. Thanks for following up on this PR.
---
If your project is set up
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r14936355
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
---
@@ -132,4 +135,17 @@ object YarnSparkHadoopUtil {
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49039069
This PR conflicts with pr1112. I would like to put that one in first and
then upmerge this.
---
If your project is set up for it, you can reply to this email and have
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r14936811
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -172,6 +172,8 @@ class HistoryServer(
object HistoryServer {
Github user tsudukim commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49069859
OK, thank you for your reply.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49083255
@rahulsinghaliitd can you please upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tsudukim commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-48990919
Is someone working on this? or facing some problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47250080
Generally we ask for the PR submitter to resolve conflicts. You just have
to rebase your branch on top of master, resolve conflicts, and force push it
into your repo, the
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47064230
@vanzin I was only referring to how the UI URL is passed around. I have
used the longer way of passing it around using command line arguments whereas
the other
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47125879
@rahulsinghaliitd ah, good point. Passing as a SparkConf property should
work now that I fixed some things in the yarn-cluster backend.
---
If your project is set up for
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47126414
Latest patch LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47126454
(Aside from rebasing to fix the merge conflicts.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47184407
Am I supposed to resolve the conflicts or will they be resolved by the
admin who merges this change?
---
If your project is set up for it, you can reply to
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46869006
@rahulsinghaliitd that bug is about linking to the running web ui of the
driver in yarn-client mode. Slightly different than this one, which is about
setting the link
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46804664
@sryza thanks for the thumbs up.
Although I wonder if the approach in
https://github.com/apache/spark/pull/1112 is better for passing the UI address
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46732050
This change looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46201382
Hi @rahulsinghaliitd,
Thanks for filing this; this is something I had on my radar but hadn't
gotten down to it yet.
While I also want the feature, I
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46213984
Hi @vanzin,
I don't have any preference as to how the URL is formatted and I think that
changing the URL can be a separate activity. I am hoping this
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/1094
SPARK-2150: Provide direct link to finished application UI in yarn resou...
...rce manager UI
Use the event logger directory to provide a direct link to finished
application UI
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46141864
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
37 matches
Mail list logo
