[GitHub] spark pull request: SPARK-2226: transform HAVING clauses with unre...

2014-07-19 Thread willb
GitHub user willb opened a pull request:

https://github.com/apache/spark/pull/1497

SPARK-2226:  transform HAVING clauses with unresolvable attributes

This commit adds an analyzer rule to
  1. find expressions in `HAVING` clause filters that depend on unresolved 
attributes, 
  2. push these expressions down to the underlying aggregates, and then
  3. project them away above the filter.

It also enables the `HAVING` queries in the Hive compatibility suite.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/willb/spark spark-2226

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1497


commit 29a26e3ab6a21e6619f003d905bc7aa7d1cb2976
Author: William Benton wi...@redhat.com
Date:   2014-07-17T15:36:37Z

Added rule to handle unresolved attributes in HAVING clauses (SPARK-2226)

commit c7f2b2c8a19b09ec095a316cb965f18d474d7144
Author: William Benton wi...@redhat.com
Date:   2014-07-17T17:16:18Z

Whitelist HAVING queries.

Also adds golden outputs for HAVING tests.

commit 5a12647c169ee06bba5355c3956a158699247e43
Author: William Benton wi...@redhat.com
Date:   2014-07-19T17:08:17Z

Explanatory comments and stylistic cleanups.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-2226: transform HAVING clauses with unre...

2014-07-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1497#issuecomment-49535141
  
QA tests have started for PR 1497. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16860/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---