[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49513281 Thanks! I've merged this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-18 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49407883 @egraldlo @willb thanks guys, substring is also added, @marmbrus test also done and passed. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49479943 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49480325 QA tests have started for PR 1442. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16834/consoleFull ---

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49488836 QA results for PR 1442:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-17 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49379575 added a simple test in SQLQuerySuite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-17 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49381658 and... how can i run a single test class using maven? i tried: mvn -Pyarn -Phive -Dhadoop.version=2.3.0-cdh5.0.3 -Dtest=SQLQuerySuite test but it does not work

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49382058 I don't know how do it with maven but with sbt: `sbt/sbt sql/test-only org.apache.spark.sql.SQLQuerySuite` --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49155058 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-16 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49159849 That was my thought as well, @egraldlo. Thanks for submitting this, @chutium! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-16 Thread egraldlo
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49160379 thx @willb, maybe protected val SUBSTRING = Keyword(SUBSTRING) as well, but this will cause the code redundance. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-16 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49160982 @egraldlo, couldn't it be `(SUBSTR | SUBSTRING) ~ // ... ` in that case? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-16 Thread egraldlo
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49161743 fine, that's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this