Github user chutium commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-49154812
hi, it is really very useful for us, i tried this implementation from
@willb , in spark-shell, i still got java.lang.UnsupportedOperationException by
Query Plan, i made
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-49155240
Awesome! Please submit a pull request with that addition.
On Jul 16, 2014 7:53 AM, Teng Qiu notificati...@github.com wrote:
hi, it is really very useful for
Github user chutium commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-49159677
PR submitted #1442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-49093280
Thanks! Merged into master and 1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1359
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48969318
Hey Will, this looks great. Thanks for implementing! Mind fixing the
conflict with master so I can merge?
---
If your project is set up for it, you can reply to this
Github user willb commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48971559
Thanks, Michael. I've fixed the conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48971609
Thanks! Will merge as soon as Jenkins comes back happy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14915562
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -205,3 +207,72 @@ case class EndsWith(left:
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48986821
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48987029
QA tests have started for PR 1359. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16652/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48991417
QA results for PR 1359:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brcase class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48639097
QA tests have started for PR 1359. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16506/consoleFull
---
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14781579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -19,8 +19,11 @@ package
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14781690
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14781542
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14782197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class StartsWith(left:
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14782267
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -860,6 +860,7 @@ private[hive] object HiveQl {
val BETWEEN =
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14782431
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -860,6 +860,7 @@ private[hive] object HiveQl {
val BETWEEN =
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14782583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14782682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class
Github user concretevitamin commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48642397
Hey @willb - thanks for working on this, which is going to be very useful
for Spark SQL. I left a couple minor comments. Another general concern is the
Github user willb commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48643276
Thanks for the comments, @concretevitamin. I've made the changes from your
comments and will think about reducing branch overhead before pushing an update.
---
If your
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14783468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class StartsWith(left:
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14783626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class StartsWith(left:
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14783724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +210,64 @@ case class
Github user willb commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48648670
@concretevitamin Inlining `Substring.slice` seems to make a nontrivial
difference (~11.5% speedup) on a very simple `Substring.eval()` microbenchmark.
---
If your project
Github user concretevitamin commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48648864
This sounds pretty cool!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48651882
QA results for PR 1359:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brcase class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48651895
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48651897
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16506/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48653871
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48653881
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48654045
QA tests have started for PR 1359. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16513/consoleFull
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48665810
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48665803
QA results for PR 1359:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brcase class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14801757
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +207,71 @@ case class StartsWith(left:
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1359#discussion_r14802394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -207,3 +207,71 @@ case class StartsWith(left:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48685301
QA tests have started for PR 1359. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16543/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48685347
QA results for PR 1359:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brcase class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1359#issuecomment-48690227
QA results for PR 1359:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):brcase class
41 matches
Mail list logo
