[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73186449 Ok but isn't it more straightforward to at last depend on the real servlet API artifact? This is just Jetty's random copy. Maybe just fine or necessary for a reason I

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73162989 LGTM too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73162493 I discussed this approach with @vanzin previously. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/4411 SPARK-5557: Explicitly include servlet API in dependencies. Because of the way we shade jetty, we lose its dependency orbit in the assembly jar, which includes the javax servlet API's. This

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73162885 [Test build #26873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26873/consoleFull) for PR 4411 at commit

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread ksakellis
Github user ksakellis commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73162789 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73170989 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4411#issuecomment-73170983 [Test build #26873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26873/consoleFull) for PR 4411 at commit

[GitHub] spark pull request: SPARK-5557: Explicitly include servlet API in ...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is