[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75132649 [Test build #27736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27736/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75132183 Hi @andrewor14 - Can you please review the language for the other driver options and let me know if you agree with it? Thanks! --- If your project is set up for it,

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75103910 Yes, those won't work either if the user sets them through the conf. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25010513 --- Diff: docs/configuration.md --- @@ -115,6 +115,8 @@ of the most common options to set are: td Amount of memory to use for the driver

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75148808 [Test build #27736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27736/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75148820 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75153042 What is a MiMa test failure?? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75154539 MiMa is the check for changing public API signatures. This is a false positive since you didn't change any code, so don't worry about it, although a rebase might clear it

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25037005 --- Diff: docs/configuration.md --- @@ -221,6 +234,10 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25037008 --- Diff: docs/configuration.md --- @@ -228,6 +245,10 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75162511 I'm happy to help :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25009940 --- Diff: docs/configuration.md --- @@ -115,6 +115,8 @@ of the most common options to set are: td Amount of memory to use for the driver

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75160545 [Test build #27754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27754/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75157170 Got it - I wanted to break up the text. That's a good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75161356 Hi @ilganeli thanks for reiterating on my comments quickly. I think this is pretty close to being merged. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75164059 Ok, LGTM I'm merging this into master and 1.3 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75167805 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75172825 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75172814 [Test build #27756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27756/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25036932 --- Diff: docs/configuration.md --- @@ -135,6 +139,10 @@ of the most common options to set are: Having a high limit may cause out-of-memory errors

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25035980 --- Diff: docs/configuration.md --- @@ -115,6 +115,8 @@ of the most common options to set are: td Amount of memory to use for the driver

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25036036 --- Diff: docs/configuration.md --- @@ -789,7 +803,7 @@ Apart from these, the following properties are also available, and may be useful td(local

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25036894 --- Diff: docs/configuration.md --- @@ -237,6 +258,8 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75167799 [Test build #27755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27755/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75169548 [Test build #27754 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27754/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75169557 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25037050 --- Diff: docs/configuration.md --- @@ -237,6 +258,8 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75161177 [Test build #27755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27755/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4665#discussion_r25036963 --- Diff: docs/configuration.md --- @@ -214,6 +222,11 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75163701 [Test build #27756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27756/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75167564 [Test build #27752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27752/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-75167577 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-74920473 Hey @ilganeli thanks for doing this. Can you also do this for the other `spark.driver.*` options? Like extra java opts, class paths etc. --- If your project is set

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-18 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-74931272 Sure @andrewor14 , I presume their behavior is identical ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-17 Thread ilganeli
GitHub user ilganeli opened a pull request: https://github.com/apache/spark/pull/4665 SPARK-5570: No docs stating that `new SparkConf().set(spark.driver.memory, ...) will not work I've updated documentation to reflect true behavior of this setting in client vs. cluster mode. You

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-74782476 [Test build #27663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27663/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-74791514 [Test build #27663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27663/consoleFull) for PR 4665 at commit

[GitHub] spark pull request: SPARK-5570: No docs stating that `new SparkCon...

2015-02-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4665#issuecomment-74791522 Test PASSed. Refer to this link for build results (access rights to CI server needed):