[GitHub] spark pull request: fix compile error of streaming project

2014-07-16 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49144416 Seems harmless as it only makes the return type of the method explicit. I can't see why it would be specific to building with one version of Hadoop though. Maybe it isn't?

[GitHub] spark pull request: fix compile error of streaming project

2014-07-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49207773 Merging this in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: fix compile error of streaming project

2014-07-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49207755 I think I've seeen this happening once in a while, but can't exactly reproduce after clean. Anyway it's better to explicitly define the return type for public methods, even

[GitHub] spark pull request: fix compile error of streaming project

2014-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: fix compile error of streaming project

2014-07-15 Thread gzm55
Github user gzm55 commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49118864 @rxin @tdas sorry for being so late. here is a jira for this issue: https://issues.apache.org/jira/browse/SPARK-2507 when I build with 2.0.0-cdh4.6.0,

[GitHub] spark pull request: fix compile error of streaming project

2014-07-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49120758 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: fix compile error of streaming project

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49121028 QA tests have started for PR 153. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16706/consoleFull ---

[GitHub] spark pull request: fix compile error of streaming project

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-49125533 QA results for PR 153:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: fix compile error of streaming project

2014-07-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-48388499 @gzm55 Can you please close the PR if you think this is not necessary any more? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: fix compile error of streaming project

2014-06-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-47072491 @gzm55 can you explain the compilation error? Otherwise we should close the pull request. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: fix compile error of streaming project

2014-03-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-38881883 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: fix compile error of streaming project

2014-03-18 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/153#issuecomment-38005988 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have